Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change video-processing sample to process on a worker #1436

Open
dogben opened this issue May 3, 2021 · 2 comments
Open

Change video-processing sample to process on a worker #1436

dogben opened this issue May 3, 2021 · 2 comments
Assignees

Comments

@dogben
Copy link
Collaborator

dogben commented May 3, 2021

Following up to w3c/mediacapture-transform#28, the sample at https://github.com/webrtc/samples/tree/gh-pages/src/content/insertable-streams/video-processing should be changed to (optionally?) process the video on a worker rather than the main thread.

@dogben dogben self-assigned this May 3, 2021
@fippo
Copy link
Collaborator

fippo commented Apr 7, 2022

@dogben do you still want to do this? The cropping sample uses a worker so we have an example of how it should be done

@dogben
Copy link
Collaborator Author

dogben commented Apr 8, 2022

I think it would be a good idea, since the final spec that reached consensus (https://www.w3.org/TR/mediacapture-transform/) has the MediaStreamTrackProcessor and VideoTrackGenerator exposed only on DedicatedWorker. Making the sample fully spec-compliant seems desirable.

@alvestrand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants