Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom button cleanup & toolbar button styles #1794

Merged
merged 8 commits into from
May 21, 2024

Conversation

emma-sg
Copy link
Member

@emma-sg emma-sg commented May 8, 2024

Closes #1791

Screen_Recording_2024-05-08_at_4.13.23_PM.mov
Screenshots
Screenshot 2024-05-08 at 6 13 53 PM

@emma-sg emma-sg added the front end Requires front end dev work label May 8, 2024
@emma-sg emma-sg requested review from SuaYoo and Shrinks99 May 8, 2024 22:10
@emma-sg emma-sg self-assigned this May 8, 2024
@emma-sg emma-sg marked this pull request as ready for review May 15, 2024 22:00
Copy link
Collaborator

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few initial questions!

frontend/src/components/ui/copy-field.ts Outdated Show resolved Hide resolved
frontend/src/components/ui/copy-field.ts Outdated Show resolved Hide resolved
frontend/src/components/ui/button.ts Show resolved Hide resolved
@emma-sg emma-sg marked this pull request as draft May 16, 2024 06:15
@emma-sg emma-sg changed the title QA navbar button updates Custom button cleanup & toolbar button styles May 16, 2024
@SuaYoo SuaYoo self-requested a review May 21, 2024 17:15
@emma-sg emma-sg marked this pull request as ready for review May 21, 2024 17:22
@emma-sg emma-sg merged commit 040d1b7 into main May 21, 2024
2 checks passed
@emma-sg emma-sg deleted the frontend-qa-navbar-button-updates branch May 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front end Requires front end dev work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA fast-follow: Make screenshot toggle button more button-like and obvious
3 participants