New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: No ads in replay on some sites eventhough the ads are shown in the brave profile or online #1606
Comments
I checked this morning again and only replay of berlingske.dk can't show the ads. tv2.dk and politiken.dk are replaying some of the ads. |
Hi @tuehlarsen , in 1.9.4 we changed the default crawler version to the latest 1.0.0 beta, that may be responsible for the change. Could you try that crawl again with the "Previous" crawler channel (which is set to 0.12.4) to see if that works? You can find the crawler channel selector in Edit Workflow under Browser Settings: Here's the relevant section in the docs: https://docs.browsertrix.cloud/user-guide/workflow-setup/#crawler-release-channel |
I tried with the previous crawler version with berlingske.dk - it just ignores the browser profile totally and the accept of cookies. |
The crash in this case was due to sitemap parsing - we have a fix for this shortly, webrecorder/browsertrix-crawler#496 - in the meantime, disable 'Use Sitemap' for this crawl and try agian. |
I can see all adds in a brave browser from a danish ip without shields activated, so perhaps a browsertrix replay issue? |
The different newssites use some different ads providers/frameworks e.g. with display of iframes with html etc. |
Re berlingske.dk : When i use the archive.Webpage desktop version from oct. 2023 [ArchiveWeb.page-0.11.3.exe] i can replay traces of the ads and play the videos in the audio/video list : https://beta.browsertrix.cloud/orgs/kb/items/upload/upload-55d89b6d-7561-43e1-a392-76c9ecd89a4f#replay |
Browsertrix Version
v1.9.4-08ee857
What did you expect to happen? What happened instead?
After the last opgrade to 1.9.4 the ads are not shown any more in replay for tv2.dk even though they are visible in the browserprofile:
here the replay af tv2.dk:
and here the the browser profile : tv2.dk med accept af cookies :
The same happens for berlingske.dk but here it is not possble to see the adds in the browser profile too - eventhough i have disabled all shields in the brave settings.
Here a snip of adds from berlingske.dk online:
and here the browser profile:
and here the brave:setttings for shields:
I can see all ads in brave with disabled shields here:
but strangely enough - it still works for politiken.dk here in replay:
Reproduction instructions
see above
Screenshots / Video
No response
Environment
No response
Additional details
No response
The text was updated successfully, but these errors were encountered: