Add additional filters to page list endpoints #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reviewed: filter by page has approval or at least one note - approved: filter by approval value - anyApproval: filter by approval value is bool (true) or None (false) - hasNotes: filter by true or false
Strings in approved list are coerced into bools or None values as appropriate, with other values ignored.
SuaYoo
approved these changes
Mar 22, 2024
|
Looks good! We could potentially doing it the pydantic/fastapi way by parsing a comma-separated list into a list, as suggested in: tiangolo/fastapi#50 but this should be good for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1617
Filters added:
Tests have also been added to ensure that results are as expected.