Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intermittent crawl timeout test failure #1621

Merged
merged 1 commit into from Mar 22, 2024
Merged

Fix intermittent crawl timeout test failure #1621

merged 1 commit into from Mar 22, 2024

Conversation

tw4l
Copy link
Contributor

@tw4l tw4l commented Mar 21, 2024

Fixes #1620

This increases the total timeout from 60 seconds to 120 seconds for crawl to complete, which should be sufficient given how intermittently the failure has been happening. Can increase it further if needed.

@ikreymer ikreymer merged commit b3b1e0d into main Mar 22, 2024
4 checks passed
@ikreymer ikreymer deleted the issue-1620-nightly-crawl-timeout-test-fix branch March 22, 2024 00:18
@tw4l tw4l mentioned this pull request Mar 26, 2024
Merged
ikreymer pushed a commit that referenced this pull request Mar 27, 2024
@tw4l
Give test_crawl_timeout 10 mins to finish (#1627)
66b4532 
Related to #1620

Follow-up to #1621,
which didn't seem to fix the problem.

I'm giving it much more time here in the hopes that it solves it (since
it's a nightly test, time shouldn't be such a pressing issue).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly crawl timeout test fails intermittently
2 participants
@tw4l @ikreymer