Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pending exclusion pagination #1578

Merged
merged 2 commits into from Mar 6, 2024

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Mar 6, 2024

Fixes #1545

Changes

  • Fixes not being able to change page
  • Fixes pagination alignment

Manual testing

  1. Log in as a crawl and run a crawl with many pagefs
  2. Watch crawl and open exclusion editor
  3. Type in an exclusion that'll add a lot of URLs to the pending list. Verify that pending list is shown with pagination aligned to right
  4. Click pagination controls. Verify page updates as expected

Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@ikreymer ikreymer changed the base branch from main to v1.9.3-work March 6, 2024 02:15
@ikreymer ikreymer self-requested a review March 6, 2024 02:19
@ikreymer
Copy link
Member

ikreymer commented Mar 6, 2024

Just needs rebasing off 1.9.3-work

@SuaYoo SuaYoo force-pushed the frontend-exclusion-pagination-fix branch from bf6d23e to d2ea728 Compare March 6, 2024 05:32
@ikreymer ikreymer merged commit 86fa61f into v1.9.3-work Mar 6, 2024
4 checks passed
@ikreymer ikreymer deleted the frontend-exclusion-pagination-fix branch March 6, 2024 05:49
ikreymer pushed a commit that referenced this pull request Mar 6, 2024
Fixes #1545

### Changes

- Fixes not being able to change page
- Fixes pagination alignment
ikreymer pushed a commit that referenced this pull request Mar 6, 2024
Fixes #1545

### Changes

- Fixes not being able to change page
- Fixes pagination alignment
ikreymer added a commit that referenced this pull request Mar 6, 2024
- Fix execution time checking by keeping lastUpdatedTime in db by
@ikreymer in #1573
- disable postcss-lit for var css
- Prevent closing tooltips from closing collection share dialog by
@SuaYoo in #1579
- Fix pending exclusion pagination by @SuaYoo in
#1578
- Fix regex escape in exclusion editor text match by @SuaYoo in
#1577

---------
Co-authored-by: emma <hi@emma.cafe>
Co-authored-by: sua yoo <sua@webrecorder.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Live exclusion editor pending exclusion page selector is broken
3 participants