Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex escape in exclusion editor text match #1577

Merged
merged 1 commit into from Mar 6, 2024
Merged

Fix regex escape in exclusion editor text match #1577

merged 1 commit into from Mar 6, 2024

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Mar 6, 2024

Fixes #1566, fixes #1544

Changes

Fixes issue where "match text" was being displayed as regex when containing special characters.

Manual testing

  1. Log in as a crawl and run a crawl
  2. Watch crawl and open exclusion editor
  3. Add exclusion as "match text" with a period, e.g. test.com. Verify text is displayed as entered
  4. Remove exclusion. Verify exclusion is removed without errors

ikreymer
ikreymer approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working! (Just need rebase of 1.9.3-work branch)

Shrinks99
Shrinks99 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works!

@SuaYoo SuaYoo changed the base branch from main to v1.9.3-work March 6, 2024 05:33
@ikreymer ikreymer merged commit b6dd376 into v1.9.3-work Mar 6, 2024
2 checks passed
@ikreymer ikreymer deleted the frontend-exclusion-fixes branch March 6, 2024 05:50
ikreymer pushed a commit that referenced this pull request Mar 6, 2024
@SuaYoo @ikreymer
Fix regex escape in exclusion editor text match (#1577)
79a217b 
- Fixes #1566, #1544

- Fixes issue where "match text" was being displayed as regex when
containing special characters.
ikreymer pushed a commit that referenced this pull request Mar 6, 2024
@SuaYoo @ikreymer
Fix regex escape in exclusion editor text match (#1577)
524bd76 
- Fixes #1566, #1544

- Fixes issue where "match text" was being displayed as regex when
containing special characters.
@ikreymer ikreymer mentioned this pull request Mar 6, 2024
Merged
ikreymer added a commit that referenced this pull request Mar 6, 2024
@ikreymer
Merge V1.9.3 changes into main (#1583)
ea494fa 
- Fix execution time checking by keeping lastUpdatedTime in db by
@ikreymer in #1573
- disable postcss-lit for var css
- Prevent closing tooltips from closing collection share dialog by
@SuaYoo in #1579
- Fix pending exclusion pagination by @SuaYoo in
#1578
- Fix regex escape in exclusion editor text match by @SuaYoo in
#1577

---------
Co-authored-by: emma <hi@emma.cafe>
Co-authored-by: sua yoo <sua@webrecorder.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

@Shrinks99 Shrinks99 Shrinks99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Removing Exclusions at Crawl Time Fails [Bug]: Exclusion Editor "Matches Text" renders escaped
3 participants
@SuaYoo @ikreymer @Shrinks99