Fix execution time checking by keeping lastUpdatedTime in db #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
force-pushed
the
fix-last-updated-op-check
branch
from
d501761
to
5bf4217
Compare
tw4l
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Looks good, thanks for the fix! Tested locally.
I'm wondering if we could get rid of status.lastUpdatedTime entirely if we're storing it in the db.
The only other place it appears to be used in the operator is is_crawl_stopping, where we'd probably be better served fetching the last updated time from the database for the same reasons as the changes in this PR?
|
We decided to do any updates to |
ikreymer
added a commit
that referenced
this pull request
Mar 6, 2024
Instead of relying on status to keep track of lastUpdatedTime, just keep track of it in the db to ensure it is property updated each time. Fixes issues on not counting execution time while avoiding previous issues of double-counting
ikreymer
added a commit
that referenced
this pull request
Mar 6, 2024
Instead of relying on status to keep track of lastUpdatedTime, just keep track of it in the db to ensure it is property updated each time. Fixes issues on not counting execution time while avoiding previous issues of double-counting
ikreymer
added a commit
that referenced
this pull request
Mar 6, 2024
- Fix execution time checking by keeping lastUpdatedTime in db by @ikreymer in #1573 - disable postcss-lit for var css - Prevent closing tooltips from closing collection share dialog by @SuaYoo in #1579 - Fix pending exclusion pagination by @SuaYoo in #1578 - Fix regex escape in exclusion editor text match by @SuaYoo in #1577 --------- Co-authored-by: emma <hi@emma.cafe> Co-authored-by: sua yoo <sua@webrecorder.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on status to keep track of lastUpdatedTime, just keep track of it in the db to ensure it is property updated each time. Fixes issues on not counting execution time while avoiding previous issues of double-counting