New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoints to read pages from older crawl WACZs into database #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
force-pushed
the
crawl-pages-oom
branch
2 times, most recently
from
March 5, 2024 21:38
7ea1272
to
89d34db
Compare
tw4l
changed the title
Await adding pages from crawls one at a time
Add migration to read pages from older crawl WACZs into database
Mar 5, 2024
@ikreymer This is ready for re-review, now with
|
tw4l
changed the title
Add migration to read pages from older crawl WACZs into database
Add endpoints to read pages from older crawl WACZs into database
Mar 7, 2024
And remove async streaming/zip parsing methods
tw4l
force-pushed
the
crawl-pages-oom
branch
2 times, most recently
from
March 14, 2024 16:44
298b8ab
to
ac81831
Compare
ikreymer
reviewed
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1597
New endpoints (replacing old migration) to re-add crawl pages to db from WACZs.
After a few implementation attempts, we settled on using remotezip to handle parsing of the zip files and streaming their contents line-by-line for pages. I've also modified the sync log streaming to use remotezip as well, which allows us to remove our own zip module and let remotezip handle the complexity of parsing zip files.
Database inserts for pages from WACZs are batched 100 at a time to help speed up the endpoint, and the task is kicked off using asyncio.create_task so as not to block before giving a response.
StorageOps now contains a method for streaming the bytes of any file in a remote WACZ, requiring only the presigned URL for the WACZ and the name of the file to stream.