Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly crawl timeout test fails intermittently #1620

Closed
tw4l opened this issue Mar 21, 2024 · 0 comments · Fixed by #1621
Closed

Nightly crawl timeout test fails intermittently #1620

tw4l opened this issue Mar 21, 2024 · 0 comments · Fixed by #1621
Assignees
@tw4l

Comments

@tw4l
Copy link
Contributor

tw4l commented Mar 21, 2024

The time.sleep() we are using to wait until the crawl is finished after hitting the timeout sometimes isn't long enough, we should replace it with a while loop.
@tw4l tw4l mentioned this issue Mar 21, 2024
Merged
@tw4l tw4l self-assigned this Mar 21, 2024
ikreymer pushed a commit that referenced this issue Mar 22, 2024
@tw4l
Fix intermittent crawl timeout test failure (#1621)
b3b1e0d 
Fixes #1620 

This increases the total timeout from 60 seconds to 120 seconds for
crawl to complete, which should be sufficient given how intermittently
the failure has been happening. Can increase it further if needed.
@tw4l tw4l mentioned this issue Mar 26, 2024
Merged
ikreymer pushed a commit that referenced this issue Mar 27, 2024
@tw4l
Give test_crawl_timeout 10 mins to finish (#1627)
66b4532 
Related to #1620

Follow-up to #1621,
which didn't seem to fix the problem.

I'm giving it much more time here in the hopes that it solves it (since
it's a nightly test, time shouldn't be such a pressing issue).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw4l tw4l

Labels
None yet
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix intermittent crawl timeout test failure webrecorder/browsertrix
1 participant
@tw4l