Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): add plugin for lost-pixel config #630

Merged
merged 6 commits into from May 14, 2024

Conversation

PeterMK85
Copy link
Contributor

No description provided.

Copy link
Collaborator

@webpro webpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PeterMK85. Happy to merge this, but any chance you could add a lost pixel config file in the fixture for test coverage?

@PeterMK85
Copy link
Contributor Author

@webpro

Added an example config file.

Thank you (for the awesome project as well 🙇 )

@webpro
Copy link
Collaborator

webpro commented May 13, 2024

I'm confused:

This might have the answer: https://github.com/lost-pixel/lost-pixel/blob/main/src/config.ts#L566

The examples also don't have the dash: https://github.com/lost-pixel/lost-pixel-examples/blob/main/example-ladle/lostpixel.config.ts

@webpro webpro merged commit 24772ca into webpro-nl:main May 14, 2024
11 of 14 checks passed
@webpro
Copy link
Collaborator

webpro commented May 14, 2024

Thanks @PeterMK85!

@webpro
Copy link
Collaborator

webpro commented May 14, 2024

🚀 This pull request is included in v5.16.0. See Release 5.16.0 for release notes.

Using Knip in a commercial project? Please consider sponsoring me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants