Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chokidar to v3 for watchpack@1.x.x #137

Closed
guidobouman opened this issue Jan 7, 2020 · 6 comments
Closed

Update Chokidar to v3 for watchpack@1.x.x #137

guidobouman opened this issue Jan 7, 2020 · 6 comments

Comments

@guidobouman
Copy link

guidobouman commented Jan 7, 2020

watchpack@1.x causes chokidar@2.1.8 + fsevents@1.2.11 to be installed. Which breaks on Windows with npm ci installs.

Using chokidar@3.x in the v1.x branch allows fsvents@2.x to be installed, which allows ci installs on Windows to succeed again. With every package update, I now have to manually roll back the fsevents update. Yes, I've brought this up with the package owner, but he's also in a position where fsevents@1.x is unmaintainable. This package would benefit a lot from the update in the current v1.x branch. Because current installs of webpack / watchpack are starting to fail more & more.

@alexander-akait
Copy link
Member

We can't do it because it is breaking change, what is broken? Can you create reproducible test repo?

@guidobouman
Copy link
Author

guidobouman commented Jan 9, 2020

Would that directly cause a breaking change in the watchpack API? I don't see the need for a breaking change in watchpack to update a dependency. Or do I see this wrong?

@alexander-akait
Copy link
Member

@guidobouman webpack@4 support node@6, chokidar@3.x require node@8

@guidobouman
Copy link
Author

Hmm... You mean Node 6, which has been EOL since april 30, 2019? I get that you want to respect old versions, even if they are EOL. But should a widespread package like webpack not also push ahead the platform as a whole?

Google is decommissioning Node 6 cloud functions on April 22, 2020. And Amazon has deprecated Node 6 for Lambda functions on August 12, 2019:
https://aws.amazon.com/blogs/developer/node-js-6-is-approaching-end-of-life-upgrade-your-aws-lambda-functions-to-the-node-js-10-lts/

@alexander-akait
Copy link
Member

alexander-akait commented Jan 9, 2020

@guidobouman yes, but it will be in webpack@5 (we don't use chokidar in next version), we can't break support for node@6 projects

@guidobouman
Copy link
Author

Fair point. Sorry for pushing beyond reasonable semver logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants