Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why process commented line? #73

Closed
klihelp opened this issue Feb 1, 2017 · 4 comments
Closed

Why process commented line? #73

klihelp opened this issue Feb 1, 2017 · 4 comments
Labels

Comments

@klihelp
Copy link

klihelp commented Feb 1, 2017

On Build, Why processing commented line?

ERROR in ./src/app/app.routes.ts 
Module build failed: Error: Can't resolve './+barrel' in
at onResolved (../node_modules/enhanced-resolve/lib/Resolver.js:66:16)
// app.routes.ts  
// Comments
//  { path: 'barrel', loadChildren: './+barrel#BarrelModule'},

ps - Using latest version3+.

Similar issue in angular aot build: Cannot determine the module for class
angular/angular#13590

Potentially on ng-router-loader:
shlomiassaf/ng-router-loader#3

@klihelp
Copy link
Author

klihelp commented Jul 5, 2017

Update on this?

@mikesherov
Copy link
Contributor

Hi @klihelp thanks for contributing! Can you please provide a minimal repro case showing this bug, as I don't believe it's in enhanced-resolve.

@mikesherov
Copy link
Contributor

Yeah, this has nothing to do with enhanced-resolve, I'm pretty sure. Closing for now. If you have a minimal repro showing it's somehow related, please post it and I'll gladly reopen, thanks!

@klihelp
Copy link
Author

klihelp commented Jul 6, 2017

thanks, have to research, maybe some webpack plugin is passing forward the //commented lines ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants