Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'physical'-field on election to enum named ElectionMode #465

Open
juniwbjerde opened this issue Nov 10, 2021 · 0 comments
Open

Change 'physical'-field on election to enum named ElectionMode #465

juniwbjerde opened this issue Nov 10, 2021 · 0 comments

Comments

@juniwbjerde
Copy link
Member

Now the election model has a field pysical:
physical: { type: Boolean, default: true, },
It would make more sense if this was like the type field:
type: { type: String, enum: [ElectionTypes.NORMAL, ElectionTypes.STV], default: ElectionTypes.NORMAL, ... },

(PS: the type field has been renamed to system and uses an enum ElectionSystems in the ts brach that will be merged into master when done.)

Therefore the field 'physical' should be replaced with a field named mode (or something like that) that uses an enum ElectionMode. That way it will follow the same pattern as ElectionType/ElectionSystem, and you will be able to say explicitly that an election is digital (not just physical=false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant