Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace moment with luxon #2875

Open
ivarnakken opened this issue Aug 25, 2022 · 1 comment
Open

Replace moment with luxon #2875

ivarnakken opened this issue Aug 25, 2022 · 1 comment
Labels
enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features frontend future-is-now Pull requests that utilize cutting-edge technology or just a cool new feature level:hard

Comments

@ivarnakken
Copy link
Member

ivarnakken commented Aug 25, 2022

There's a bunch of problems with moment, e.g. being mutable and not having native timezone support. These are causing security vulnerability issues, and given that the project has been designated a legacy project by its maintainers in 2020, it should for obvious reasons be replaced.

luxon was created by some of the moment developers, and serves to be a better replacement and the worthy successor. It has been in development for some time now, and I think it is ready (but more investigation should preferably be given).

Since this would require a ton of (relatively easy) work with huge caution, I'll label this as a hard issue.

@ivarnakken ivarnakken added frontend level:hard enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features future-is-now Pull requests that utilize cutting-edge technology or just a cool new feature labels Aug 25, 2022
@eikhr
Copy link
Member

eikhr commented Aug 25, 2022

I've heard good things about date-fns, and I know there are multiple other alternatives. It might be worth doing a bit of research into different libraries before doing a lot of work on this.

But we should definitely replace moment, it's also a huge library and not tree-shakable so it adds a lot to our bundle size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features frontend future-is-now Pull requests that utilize cutting-edge technology or just a cool new feature level:hard
Projects
None yet
Development

No branches or pull requests

2 participants