Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality for changing banner on front page through abakus.no #2768

Open
ivarnakken opened this issue Jul 2, 2022 · 0 comments
Open
Assignees
Labels
backend frontend level:medium new-feature Pull requests that introduce or issues that suggest a new feature

Comments

@ivarnakken
Copy link
Member

ivarnakken commented Jul 2, 2022

As of now, the banner must be changed manually through code changes, which is neither clean nor practical. Since the banner has been receiving positive reviews and seem to have come to stay, we should introduce functionality for changing it (color, content and visibility) through abakus.no directly.

This would of course require admin permissions, however, I'm not sure "where" this should be located. Perhaps under the admin page "Kunngjøringer" or simply under an entire new admin page accessible through the hamburger menu. On that thought, perhaps it would even be nice with a new admin page solely for the front page, which could also contain functionality for pinning articles (especially needed once the new front page introduces two articles) and choosing which polls to show etc.

In addition, it's worth noting that the banner must be manually updated two places, both on the "public" and "private" front page. This is simply unpractical, and even made me forget to update one in lego-webapp/#2864.

@ivarnakken ivarnakken added new-feature Pull requests that introduce or issues that suggest a new feature backend frontend level:medium labels Jul 2, 2022
@Arashfa0301 Arashfa0301 self-assigned this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend frontend level:medium new-feature Pull requests that introduce or issues that suggest a new feature
Projects
None yet
Development

No branches or pull requests

2 participants