Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

File Upload Drag n' Drop logic rewrite #220

Open
LtSquigs opened this issue Feb 6, 2015 · 0 comments
Open

File Upload Drag n' Drop logic rewrite #220

LtSquigs opened this issue Feb 6, 2015 · 0 comments
Assignees

Comments

@LtSquigs
Copy link
Contributor

LtSquigs commented Feb 6, 2015

Right now all of this logic is done through direct editing of the template, which causes problems with the image modal because its now bound to localized text, and it also makes some of the text in the modals un-localizable. We should change this logic:

https://github.com/webhook/webhook-cms/blob/master/app/components/file-upload.js#L67-96

To instead of directly using addClass, removeClass, and text, it should set some variables on the view so these can be handled in the respective image-upload.hbs and file-upload.hbs files. This should also let us make the "Drop FIles" and "Select from Desktop" strings localizable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants