Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Checking name collisions on Taxonomy object types #445

Open
yogeshVU opened this issue Oct 18, 2023 · 2 comments
Open

Plugin: Checking name collisions on Taxonomy object types #445

yogeshVU opened this issue Oct 18, 2023 · 2 comments

Comments

@yogeshVU
Copy link
Collaborator

It will be good to check if there are any name collisions in the taxonomy especially for the json objects. Code gen tools like Pydantic creates a class with an object name and if there is a name collision, it just appends an incremental integer to the class name. Eg. Participant,,, Participant1, Partcipant2..

@brollb
Copy link
Collaborator

brollb commented Nov 1, 2023

Just to be clear, this is not just for sibling nodes in the taxonomy, right? In other words, if two nodes have the same name but have unique paths in the taxonomy tree, is that a problem?

@yogeshVU
Copy link
Collaborator Author

yogeshVU commented Nov 6, 2023

As far as my understanding goes, pydantic creates classes globally. As such this would mean unique names across the taxonomy for the objects, ignoring the unique paths if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants