Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDriverIO v5 cucumberOpts is not included in WebdriverIO.Config typescript #4215

Closed
espekkaya opened this issue Jul 18, 2019 · 3 comments · Fixed by #4318
Closed

WebDriverIO v5 cucumberOpts is not included in WebdriverIO.Config typescript #4215

espekkaya opened this issue Jul 18, 2019 · 3 comments · Fixed by #4318
Labels
good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript

Comments

@espekkaya
Copy link

espekkaya commented Jul 18, 2019

Is your feature request related to a problem? Please describe.
WebDriverIO v5 cucumberOpts is not included in typescript . I have added wdio.d.ts file but it is nice to have adding in webdriverio package.

WebDriverIO version : 5.11.5

    interface Options {
        cucumberOpts?: {
            require: string[],
            backtrace: boolean,
            requireModule: (string | object)[],
            dryRun: boolean,
            failFast: boolean,
            format: string[],
            colors: boolean,
            snippets: boolean,
            source: boolean,
            profile: string[],
            strict: boolean,
            tagExpression: string,
            timeout: number,
            ignoreUndefinedDefinitions: boolean
        }
    }
@mgrybyk
Copy link
Member

mgrybyk commented Jul 18, 2019

@espekkaya may you please rise a PR for this?

I'd also suggest making properties optional and add function type to requireModule array

@christian-bromann christian-bromann added good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript labels Jul 18, 2019
@espekkaya espekkaya reopened this Jul 18, 2019
@jayrepo
Copy link
Contributor

jayrepo commented Aug 5, 2019

@espekkaya @mgrybyk
tags: string[] shoud be tagExpression: string
https://github.com/webdriverio/webdriverio/blob/master/packages/wdio-cucumber-framework/src/constants.js

It also occurs with config generated by wdio cli

@espekkaya
Copy link
Author

@jayrepo , you are right. I have just edited right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants