-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WDIO Configuration Helper doesn't work using yarn #2319
Comments
@gsccheng please see #2218 (comment) .. I was not able to reproduce this. So either you can prepare a PR with a fix or try the suggested workaround. Thanks! |
Strange that this isn't reproducible. Here's a repo with only webdriverio as a dependency: Doing this fails: yarn
yarn run wdio
=========================
WDIO Configuration Helper
=========================
? Where do you want to execute your tests? On my local machine
? Which framework do you want to use? cucumber
? Shall I install the framework adapter for you? Yes
? Where are your feature files located? ./features/**/*.feature
? Where are your step definitions located? ./features/step_definitions/
? Which reporter do you want to use? spec - https://github.com/webdriverio/wdio-spec-reporter
? Shall I install the reporter library for you? Yes
? Do you want to add a service to your test setup? phantomjs - https://github.com/cognitom/wdio
-phantomjs-service
? Shall I install the services for you? Yes
? Level of logging verbosity verbose
? In which directory should screenshots gets saved if a command fails? ./features/errorShosts/
? What is the base url? http://localhost:3000 the console message is Installing wdio packages:
Packages installed successfully, creating configuration file...
fs.js:652
return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
^
Error: ENOENT: no such file or directory, open '/Users/tony/Code/Learn/wdio_yarn/node_modules/webdriverio/build/lib/helpers/wdio.conf.ejs'
at Object.fs.openSync (fs.js:652:18)
at Object.fs.readFileSync (fs.js:553:33)
at renderConfigurationFile (/Users/tony/Code/Learn/wdio_yarn/node_modules/webdriverio/build/lib/cli.js:292:28)
at /Users/tony/Code/Learn/wdio_yarn/node_modules/webdriverio/build/lib/cli.js:282:17
at /Users/tony/Code/Learn/wdio_yarn/node_modules/npm-install-package/index.js:31:5
at ChildProcess.exithandler (child_process.js:262:7)
at emitTwo (events.js:125:13)
at ChildProcess.emit (events.js:213:7)
at maybeClose (internal/child_process.js:927:16)
at Socket.stream.socket.on (internal/child_process.js:348:11) This command, from the base repo, successfully creates the config file: npm install
./node_modules/.bin/wdio |
I had reproduced issue using: Selected for config: After start of installation wdio had deleted half of webdriverio package. Possibly, it is associated with files structure, because packages installation with npm had solved this problem. |
I have the same issue
|
My observations:
Walk-around fix:
|
## Proposed changes Fixes #3421 , #2319 Tested with yarn. ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ### Reviewers: @webdriverio/technical-committee
Extendable typings (#3477) [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) Proposal for adding types to frameworks/services etc... Please have a look at the proposed changes here and let me know what you think. It does 2 things: - The current typings make no difference in the `suite` and `test` description, regardless of framework. Actually, they are currently describing the mocha output. However, when running jasmine, there is different output available. With this PR all you would have to do is reference the framework package in your `tsconfig.json` and it would give you the correct typings for `suite` and `test` AND give you global typings for either mocha or jasmine. - As an example I also added typings in this way for the `selenium-standalone-service`. To get the correct typings and allowed extra properties to the `config` object, all you need to do is install selenium-standalone-service and add a reference to it in the `tsconfig.json`. Look at the `typescript.md` file for a description/example. This is just a proposal, but one that would work pretty nicely I think. Ideally, all wdio packages would come with typings files like this. Please let me know what you think about this. [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) Fixed type error for CSSProperty #3473 (#3474) * Added new TypeScript boilerplate for WebdriverIO * Added Accessibility test ability to TypeScript boilerplate * Fixed type errors in Webdriverio.d.ts #3473 * Support other types of CSS attributes #3473 Updating stale element handling (#3482) [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) 1.) Firefox is not passing stale elements per the wc3 spec. Widening the scope of errors that we refetch so that we can handle firefox 2.) Flattening the middleware (this also adds the refetch to the edge case of an element falling stale after waiting for it to exist) 3.) Fixing the stale element mock 4.) Updating the UTs that expect a function toThrow to be .rejects.toThrow() 5.) Re-enabling the skipped UTs [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [X] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [X] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [X] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) Fix handling of yarn-managed node_modules (#3422) Fixes #3421 , #2319 Tested with yarn. - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) fix import - ref #3422
Extendable typings (#3477) [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) Proposal for adding types to frameworks/services etc... Please have a look at the proposed changes here and let me know what you think. It does 2 things: - The current typings make no difference in the `suite` and `test` description, regardless of framework. Actually, they are currently describing the mocha output. However, when running jasmine, there is different output available. With this PR all you would have to do is reference the framework package in your `tsconfig.json` and it would give you the correct typings for `suite` and `test` AND give you global typings for either mocha or jasmine. - As an example I also added typings in this way for the `selenium-standalone-service`. To get the correct typings and allowed extra properties to the `config` object, all you need to do is install selenium-standalone-service and add a reference to it in the `tsconfig.json`. Look at the `typescript.md` file for a description/example. This is just a proposal, but one that would work pretty nicely I think. Ideally, all wdio packages would come with typings files like this. Please let me know what you think about this. [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) Fixed type error for CSSProperty #3473 (#3474) * Added new TypeScript boilerplate for WebdriverIO * Added Accessibility test ability to TypeScript boilerplate * Fixed type errors in Webdriverio.d.ts #3473 * Support other types of CSS attributes #3473 Updating stale element handling (#3482) [//]: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.) 1.) Firefox is not passing stale elements per the wc3 spec. Widening the scope of errors that we refetch so that we can handle firefox 2.) Flattening the middleware (this also adds the refetch to the edge case of an element falling stale after waiting for it to exist) 3.) Fixing the stale element mock 4.) Updating the UTs that expect a function toThrow to be .rejects.toThrow() 5.) Re-enabling the skipped UTs [//]: # (What types of changes does your code introduce to WebdriverIO?) [//]: # (_Put an `x` in the boxes that apply_) - [X] Bugfix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) [//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._) - [X] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [X] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) [//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...) Fix handling of yarn-managed node_modules (#3422) Fixes #3421 , #2319 Tested with yarn. - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) fix import - ref #3422
## Proposed changes Fixes webdriverio#3421 , webdriverio#2319 Tested with yarn. ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ### Reviewers: @webdriverio/technical-committee
## Proposed changes Fixes webdriverio#3421 , webdriverio#2319 Tested with yarn. ## Types of changes - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist - [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ### Reviewers: @webdriverio/technical-committee
The problem
WDIO Configuration Helper doesn't work using
yarn@1.0.1
.Environment
Details
I'm opening this to track the issue that is related to here:
#2215
#2218
Link to Selenium/WebdriverIO logs
N/A
Code To Reproduce Issue [ Good To Have ]
N/A
The text was updated successfully, but these errors were encountered: