Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Biomes O' Plenty gray grass. #2318

Open
thetakodev opened this issue Sep 3, 2018 · 7 comments
Open

[Bug] Biomes O' Plenty gray grass. #2318

thetakodev opened this issue Sep 3, 2018 · 7 comments

Comments

@thetakodev
Copy link

i have an issue
Dynmap
^ there is a gray looking biome
Minecraft
Colormap is missing i guess. Leaves and grass are wrong color. How can i fix this?

@Delocuro
Copy link

Delocuro commented Sep 3, 2018

Can confirm with Minestrappolation 5's Clay Soil as well -- every white tile in this image is supposed to be sort of a lime green.
gitbug

I'm sure there's probably some step I'm missing to manually define color overlays, but I couldn't find it in any of the documentation.

@flannerby
Copy link

I have finally tracked down and also found a temp fix for this issue! DynmapBlockScan is rendering some mod blocks without biome-based coloring. Defining the block in modsupport/modname-textures.txt doesn't fix it because every time you load up DynmapBlockScan overwrites the changes. How to fix this particular issue:

  1. Copy biomesoplenty-textures.txt out one level to /renderdata folder (outside modsupport).
  2. Find the entries that start with block:id=%grass.
  3. Replace the following lines (match the data=#):

block:id=%grass,data=4,patch0=11000:txt0212,patch1=0:txt0015,patch2=11000:txt0212,patch3=11000:txt0212,patch4=1000:txt0213,patch5=11000:txt0212,stdrot=true

block:id=%grass,data=3,patch0=11000:txt0219,patch1=0:txt0020,patch2=11000:txt0219,patch3=11000:txt0219,patch4=1000:txt0213,patch5=11000:txt0219,patch6=11000:txt0220,patch7=11000:txt0220,patch8=11000:txt0220,patch9=11000:txt0220,blockcolor=txt0056,transparency=SEMITRANSPARENT,stdrot=true

block:id=%grass,data=1,patch0=11000:txt0221,patch1=0:txt0222,patch2=11000:txt0221,patch3=11000:txt0221,patch4=1000:txt0223,patch5=11000:txt0221,stdrot=true

block:id=%grass,data=2,patch0=11000:txt0224,patch1=0:txt0018,patch2=11000:txt0224,patch3=11000:txt0224,patch4=1000:txt0213,patch5=11000:txt0224,stdrot=true

The only thing i could not find a way to fix, is overgrown stone's texture rendering partially white on the sides. It looks like maybe dynmap would need to add a new modifier value that would support that block in particular because it goes further down the side than the typical modded grass block.

@Griefed
Copy link

Griefed commented May 21, 2020

The rendering for BoP seems to have changed again. Here's an example of how the current rendering for BoP seems to work (somewhat)
I can't get Overgrown Stone to work, either. Here's how my grass blocks look:
image

block:id=%grass,data=0,patch0=0:txt0001,patch1=0:txt0002,patch2=0:txt0003,patch3=0:txt0003,patch4=0:txt0003,patch5=0:txt0003,stdrot=true
block:id=%grass,data=1,patch0=0:txt0004,patch1=1000:txt0005,patch2=0:txt0004,patch3=0:txt0004,patch4=0:txt0004,patch5=0:txt0004,patch6=0:txt0004,patch7=11000:txt0005,patch8=0:txt0329,patch9=0:txt0329,patch10=0:txt0329,patch11=0:txt0329,transparency=SEMITRANSPARENT,stdrot=true
block:id=%grass,data=2,patch0=0:txt0007,patch1=1000:txt0008,patch2=11000:txt0009,patch3=11000:txt0009,patch4=11000:txt0009,patch5=11000:txt0009,stdrot=true
block:id=%grass,data=3,patch0=0:txt0010,patch1=1000:txt0008,patch2=11000:txt0011,patch3=11000:txt0011,patch4=11000:txt0011,patch5=11000:txt0011,stdrot=true
block:id=%grass,data=4,patch0=0:txt0012,patch1=1000:txt0008,patch2=11000:txt0013,patch3=11000:txt0013,patch4=11000:txt0013,patch5=11000:txt0013,stdrot=true
block:id=%grass,data=5,patch0=0:txt0014,patch1=0:txt0015,patch2=0:txt0327,patch3=0:txt0327,patch4=0:txt0327,patch5=0:txt0327,stdrot=true
block:id=%grass,data=6,patch0=0:txt0017,patch1=0:txt0018,patch2=0:txt0019,patch3=0:txt0019,patch4=0:txt0019,patch5=0:txt0019,stdrot=true
block:id=%grass,data=7,patch0=0:txt0014,patch1=1000:txt0020,patch2=0:txt0330,patch3=0:txt0330,patch4=0:txt0330,patch5=0:txt0330,stdrot=true
block:id=%grass,data=8,patch0=0:txt0017,patch1=0:txt0022,patch2=0:txt0023,patch3=0:txt0023,patch4=0:txt0023,patch5=0:txt0023,stdrot=true

biomesoplenty-texture.txt

@Kinami37
Copy link

Still an issues as of now, grey stone-y blocks insteda of BoP grass, same issue for me.

@raffitz
Copy link

raffitz commented Mar 17, 2021

I grabbed the renderdata files generated by Dynmap Block Scan, modified them a bit, and got them to display the grass correctly. This was made with MC 1.12.2, Dynmap 3.0.1, Biomes O'Plenty 7.0.1.2444. Different versions might not work all that well, no guarantees. I also included a fix for the fluids (blood, honey, hot springs, poison, quicksand).

Both files are necessary (the models and the texture).

https://gist.github.com/raffitz/71e544e3f01aa484b765f3b67070a052

@generrosity
Copy link
Collaborator

Folks, there has been a major release of Dynmap, and colour and biome colour was one of the things recently fixed.

Please do give it a go, and check out the alpha blockscan if you are brave too.

@ItzPear
Copy link

ItzPear commented Apr 15, 2022

This is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants