Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextual properties for ValidationException #809

Open
PawelJ-PL opened this issue Aug 9, 2023 · 3 comments
Open

Contextual properties for ValidationException #809

PawelJ-PL opened this issue Aug 9, 2023 · 3 comments

Comments

@PawelJ-PL
Copy link

Hi,

I think it would be a significant improvement if ValidationException errors (or at least some of them) included additional attributes containing contextual information. For instance, in the case of a BadOriginException, this attribute could be clientOrigin. Currently, to obtain this information, we need to parse the error message (The collectedClientData " + clientOrigin + " origin doesn't match any of the preconfigured server origin.). With such an approach, there's a risk that the message might change in the future, catching us off guard.

@ynojima
Copy link
Member

ynojima commented Aug 13, 2023

Thank you for pointing this out.
Started Working on it in #811

@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 15, 2023
@PawelJ-PL
Copy link
Author

Bumping, just so the issue doesn't get closed.

@stale stale bot removed the wontfix This will not be worked on label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants