Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leds support on mainline devices #25

Open
Herrie82 opened this issue Dec 8, 2023 · 2 comments
Open

Add leds support on mainline devices #25

Herrie82 opened this issue Dec 8, 2023 · 2 comments

Comments

@Herrie82
Copy link
Collaborator

Herrie82 commented Dec 8, 2023

Is your feature request related to a problem? Please describe.
We have a nyx-modules for leds for hybris based devices, would be good to replicate for mainline since there is proper led support in kernels now.

We might want to bring back CoreNaviLeds in luna-sysmgr: webOS-ports/luna-sysmgr@f9973a3

Describe the solution you'd like
Replicate above for mainline. led can be enabled by setting brightness value. "echo 100 > brightness"

root@pinephonepro:/sys/class/leds# ls -l
lrwxrwxrwx 1 root root 0 Apr 28 2022 blue:indicator -> ../../devices/platform/leds/leds/blue:indicator
lrwxrwxrwx 1 root root 0 Apr 28 2022 green:indicator -> ../../devices/platform/leds/leds/green:indicator
lrwxrwxrwx 1 root root 0 Apr 28 2022 mmc2:: -> ../../devices/platform/fe330000.mmc/leds/mmc2::
lrwxrwxrwx 1 root root 0 Apr 28 2022 red:indicator -> ../../devices/platform/leds/leds/red:indicator
lrwxrwxrwx 1 root root 0 Apr 28 2022 white:flash -> ../../devices/platform/led-controller/leds/white:flash

Additional context
See also: https://source.puri.sm/Librem5/feedbackd/-/blob/main/src/fbd-ledctrl.c
https://source.puri.sm/Librem5/feedbackd/-/blob/main/src/fbd-dev-led-multicolor.c
https://source.puri.sm/Librem5/feedbackd/-/blob/main/src/fbd-dev-led.c
https://source.puri.sm/Librem5/feedbackd/-/blob/main/src/fbd-dev-leds.c
https://source.puri.sm/Librem5/feedbackd/-/blob/main/src/fbd-feedback-led.c

@Tofee
Copy link
Member

Tofee commented Dec 16, 2023

@Herrie82
Copy link
Collaborator Author

I think that only does lcd backlight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants