Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table]: Minor improvements #1031

Open
mattjaf opened this issue Feb 6, 2023 · 1 comment
Open

[Table]: Minor improvements #1031

mattjaf opened this issue Feb 6, 2023 · 1 comment
Labels
feature New feature or request help wanted Extra attention is needed ready for dev this issue is ready to be picked up

Comments

@mattjaf
Copy link
Contributor

mattjaf commented Feb 6, 2023

Pretty much, whenever I open the modal it sends the table back to page 1, as well as, If i open a modal after sorting it reverts back to page one w/o sorting, hindering the user experience.

Is there a way to store the state of the Current page & sorting within the URL or something?
@mattjaf mattjaf changed the title The table's pagination and sorting doesn't seem to hold its state when implementing a onOpen for a modal The table's pagination and sorting doesn't seem to hold its state when implementing a onOpen function for a modal Feb 6, 2023
@AbhinavMV
Copy link
Collaborator

Thankyou @mattjaf 🙌🏻
Currently table does not have such a solution, if someone from the community can pick this up it will be great. :)

More Info about the issue:

  1. remove pagination component used inside table, and use the one created from kit. Expose the current page prop of that component from table. This will make the table controlled
  2. find solution to save sorting context
  3. Add a prop so that table cannot be reset to first page if table data changes. (I think solving 1st point will solve else solve this too)

@AbhinavMV AbhinavMV added feature New feature or request help wanted Extra attention is needed ready for dev this issue is ready to be picked up labels Feb 7, 2023
@AbhinavMV AbhinavMV changed the title The table's pagination and sorting doesn't seem to hold its state when implementing a onOpen function for a modal [Table]: Minor improvements Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request help wanted Extra attention is needed ready for dev this issue is ready to be picked up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattjaf @AbhinavMV