Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insure web3modal/web3 functionality is similar to the other web3modals #6997

Closed
Muhammad-Altabba opened this issue Apr 23, 2024 · 1 comment
Closed

Insure web3modal/web3 functionality is similar to the other web3modals #6997

Muhammad-Altabba opened this issue Apr 23, 2024 · 1 comment
Assignees
@luu-alex
Labels
4.x 4.0 related

Comments

@Muhammad-Altabba
Copy link
Contributor

Double check (and fix) the web3modal/web3 draft code to insure its functioning properly.

Changes to be maid in an MR to https://github.com/ChainSafe/web3modal/tree/feat/support-web3js
@luu-alex
Copy link
Contributor

luu-alex commented Apr 23, 2024 •
edited

In default laboratory,
Signing a transaction will fail when it should sign properly,

Contract write is failing to estimate gas
it should estimate when interacting with the smart contract button
edit: fixed

Wallets such as phantom is failing when rejecting to sign/send a transaction

@mconnelly8 mconnelly8 added the 4.x 4.0 related label Apr 25, 2024
@luu-alex luu-alex mentioned this issue Apr 30, 2024
Closed
This was referenced May 4, 2024
Closed
Closed
@luu-alex luu-alex removed the Estimate label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luu-alex luu-alex

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Muhammad-Altabba @luu-alex @mconnelly8