Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align modal title to MD3 guidelines for full-screen dialogs #282

Open
fabriziocucci opened this issue Apr 16, 2023 · 2 comments
Open

Align modal title to MD3 guidelines for full-screen dialogs #282

fabriziocucci opened this issue Apr 16, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@fabriziocucci
Copy link

Based on MD3 guidelines for full-screen dialogs, I believe the label should appear in the top app bar, next to the X icon.

Is there a chance to align to the guideline or provide an option to decide where the label should be placed?

header
@fabriziocucci fabriziocucci added the question Further information is requested label Apr 16, 2023
@iM-GeeKy iM-GeeKy added enhancement New feature or request good first issue Good for newcomers labels Apr 16, 2023
@iM-GeeKy
Copy link
Collaborator

PRs are welcome!

@fabriziocucci fabriziocucci changed the title Any chance the Modal title can be aligned to the MD3 guidelines for full-screen dialogs? Align Modal title to MD3 guidelines for full-screen dialogs Apr 16, 2023
@fabriziocucci fabriziocucci changed the title Align Modal title to MD3 guidelines for full-screen dialogs Align modal title to MD3 guidelines for full-screen dialogs Apr 16, 2023
@RichardLindhout
Copy link
Member

Good point, we want to keep support for m2 as long as react-native-paper also has support for it but we can check the theme.isV3 to align with the guidelines. PR is welcome indeed,!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RichardLindhout @iM-GeeKy @fabriziocucci