Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicitly label .tentative tests #3578

Open
saschanaz opened this issue Nov 2, 2023 · 1 comment
Open

More explicitly label .tentative tests #3578

saschanaz opened this issue Nov 2, 2023 · 1 comment

Comments

@saschanaz
Copy link
Member

One should be able to see it's not in the spec by seeing .tentative somewhere in the test file name, but it's not super visible:

  • my-amazing-web-platform-test.tentative.html - reasonably visible I guess?
  • my-really-amazing-web-platform-test.https.tentative.any.serviceworker.html - well, it's there in a pile of other modifiers...

One could also just highlight the word by Control+F, but maybe it would be better it's more explictly labeled or highlighted by default.

(And maybe exclude it while counting total test count? 🤔)

@zcorpan
Copy link
Member

zcorpan commented Nov 2, 2023

There's a search query if you want to count or exclude from the count:

  • is:tentative
  • is:!tentative

But a visible by default indicator (a separate column?) seems nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants