Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a reviewer has previously unassigned the review, don't reassign it to them #54

Open
gsnedders opened this issue Nov 23, 2018 · 3 comments

Comments

@gsnedders
Copy link
Member

#51 started automatically assigning issues to reviewers.

Some directories are a bit large, and some reviewers might not feel comfortable reviewing everything.

As a first rough approximation, if the issue has previously been assigned to [X] we should assign it to [X] to review.

Note this isn't perfect, because we might also want to unassign PRs if someone is travelling, for example.

@foolip
Copy link
Member

foolip commented Nov 30, 2018

Good idea. This can be determined from the PR itself and doesn't require storing state in wpt-pr-bot.

Can you file a separate issue for vacation logic if you have a proposed fix?

@gsnedders
Copy link
Member Author

Can you file a separate issue for vacation logic if you have a proposed fix?

I don't, sadly. That I believe is a much harder problem, esp. given it seems unlikely that orgs will be willing to expose any vacation data they have for their employees (and that doesn't work for people not in those orgs).

@zcorpan
Copy link
Member

zcorpan commented Jan 9, 2019

More generally, I think the bot should only assign once per PR. If I unassign the person the bot had assigned, it's annoying for the bot to automatically assign somebody else. (e.g. web-platform-tests/wpt#14703 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants