Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected non-OK test statuses will stop Interop scores updating #143

Open
DanielRyanSmith opened this issue Jan 24, 2023 · 4 comments
Open

Comments

@DanielRyanSmith
Copy link
Contributor

If any non-OK test status occurs in any labeled test that is being scored for interoperability, and that test was not added to the list of non-OK statuses to ignore in the code, the entirety of the score update GitHub Action will fail, and interop scores will not be updated unless the test is either investigated and explicitly added to to the list of ignored tests statuses.

Because the results are checked for all major parallel browser runs over time, any test that has ever encountered a non-OK test status will need to be added to this list or the interop score will no longer update. This includes transient errors like the one for /css/css-scroll-snap/snap-at-user-scroll-end.html. This test incurred a non-OK test status (timeout) on this run, but has not seen another non-OK status afterward. However, the entirety of Interop scoring will be halted until this test is permanently added to the list of known non-OK test statuses indefinitely.

@DanielRyanSmith
Copy link
Contributor Author

FYI @foolip @jgraham

@foolip
Copy link
Member

foolip commented Jan 25, 2023

@gsnedders
Copy link
Member

note we now haven't had any updated stats for over a week due to this

@foolip
Copy link
Member

foolip commented Feb 7, 2023

Fixing:
web-platform-tests/wpt#38387
#146

But I also think our setup is too fragile, it's not the right tradeoff for all Interop 2023 updates to stop and have to be investigated/fixed by the interop team because of a regression in one focus area. I'll send a PR with what I think we should do. I'll create an issue in the interop repo to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants