Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-properties-values-api] Test coverage for "<string>" component name #389

Open
zrhoffman opened this issue Aug 3, 2023 · 13 comments
Open

[css-properties-values-api] Test coverage for "<string>" component name #389

zrhoffman opened this issue Aug 3, 2023 · 13 comments
Labels
focus area: Custom Properties test-change-proposal Proposal to add or remove tests for an interop area

Comments

@zrhoffman
Copy link

zrhoffman commented Aug 3, 2023 •
edited

Test List

Test <string> test coverage PR
https://wpt.live/css/css-properties-values-api/at-property.html web-platform-tests/wpt#43757
https://wpt.live/css/css-properties-values-api/register-property-syntax-parsing.html web-platform-tests/wpt#41308

Rationale

A css-properties-values-api editor accepted a proposal to add the "<string>" component name in w3c/css-houdini-drafts#1103. Once the spec is updated, this new syntax component name will need WPT coverage.
@zrhoffman zrhoffman added the test-change-proposal Proposal to add or remove tests for an interop area label Aug 3, 2023
@zrhoffman zrhoffman mentioned this issue Aug 3, 2023
Open
@lilles
Copy link
Member

lilles commented Aug 3, 2023

sgtm

@nt1m
Copy link
Member

nt1m commented Aug 9, 2023

Seems ok, although note that this is CSS.registerProperty() not @property

@nt1m
Copy link
Member

nt1m commented Aug 9, 2023

I would want the spec PR to be merged before merging the WPT PR fwiw.

@lilles
Copy link
Member

lilles commented Aug 9, 2023

Seems ok, although note that this is CSS.registerProperty() not @property

Yes, we should add tests for <string> here too: http://wpt.live/css/css-properties-values-api/at-property.html

I would want the spec PR to be merged before merging the WPT PR fwiw.

Yes, that's why I blocked web-platform-tests/wpt#41308

@zcorpan zcorpan mentioned this issue Oct 12, 2023
Merged
@foolip
Copy link
Member

foolip commented Dec 20, 2023

https://wpt.fyi/results/css/css-properties-values-api/register-property-syntax-parsing.html?label=experimental&label=master&aligned is now fully passing in all browsers.

The practical benefit of including it now is very low, but also fine if we can get the spec PR merged and signoff from Mozilla here before EOY.

zrhoffman added a commit to zrhoffman/wpt that referenced this issue Dec 20, 2023
@zrhoffman
[css-properties-values-api] Add test coverage for <string> syntax in @…
76b713d 
…Property

Probably this should not be merged until w3c/css-houdini-drafts#1103 is
resolved/the spec is updated.

Interop bug: web-platform-tests/interop#389

Test coverage for `<string>` syntax in `CSS.registerProperty` is in
wpt/pull#41308.
zrhoffman added a commit to zrhoffman/wpt that referenced this issue Dec 20, 2023
@zrhoffman
[css-properties-values-api] Add test coverage for <string> syntax in @…
b9afe05 
…Property

Probably this should not be merged until w3c/css-houdini-drafts#1103 is
resolved/the spec is updated.

Interop bug: web-platform-tests/interop#389

Test coverage for `<string>` syntax in `CSS.registerProperty` is in
web-platform-tests#41308.
@zrhoffman zrhoffman mentioned this issue Dec 20, 2023
Open
@zrhoffman
Copy link
Author

Seems ok, although note that this is CSS.registerProperty() not @property

Yes, we should add tests for <string> here too: http://wpt.live/css/css-properties-values-api/at-property.html

Tests added in web-platform-tests/wpt#43757.

@zrhoffman
Copy link
Author

https://wpt.fyi/results/css/css-properties-values-api/register-property-syntax-parsing.html?label=experimental&label=master&aligned is now fully passing in all browsers.

The practical benefit of including it now is very low, but also fine if we can get the spec PR merged and signoff from Mozilla here before EOY.

cc: @emilio

@emilio
Copy link

emilio commented Dec 20, 2023

Sounds good to me.

@nairnandu nairnandu mentioned this issue Dec 21, 2023
Closed
@foolip
Copy link
Member

foolip commented Mar 12, 2024

w3c/css-houdini-drafts#1103 has still not been merged and Interop 2023 is now closed and the dashboard isn't being updated. I'll close this, but someone please reopen if we should do something retroactively here.

@foolip foolip closed this as completed Mar 12, 2024
@zrhoffman
Copy link
Author

w3c/css-houdini-drafts#1103 has still not been merged and Interop 2023 is now closed and the dashboard isn't being updated. I'll close this, but someone please reopen if we should do something retroactively here.

@foolip The Custom Properties focus area is carried over from Interop 2023 to Interop 2024, so #389 should probably stay open.

@foolip
Copy link
Member

foolip commented Mar 13, 2024

@zrhoffman sorry, my bad!

@foolip foolip reopened this Mar 13, 2024
@foolip
Copy link
Member

foolip commented Apr 4, 2024

w3c/css-houdini-drafts#1104 is the PR for this change that we should keep an eye on.

@zrhoffman
Copy link
Author

The spec is updated. WPT PRs needing review: web-platform-tests/wpt#43757, web-platform-tests/wpt#41308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus area: Custom Properties test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@foolip @lilles @emilio @nt1m @zrhoffman