[Bug]: afterBuild is not running when rebuild with watch option

[chenyuncai]

Version

Progress: resolved 1, reused 0, downloaded 1, added 1, done

  System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 AMD Ryzen 7 5800H with Radeon Graphics
    Memory: 1.98 GB / 13.87 GB
  Browsers:
    Edge: Chromium (123.0.2420.97)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @modern-js/eslint-config: 2.49.2 => 2.49.2
    @modern-js/module-tools: 2.49.2 => 2.49.2
    @modern-js/plugin-rspress: 1.19.1 => 1.19.1

Details

Begin with the modern npm package development guide and try to add a plugin to run a task after build everytime, but just trigger the plugin first time built

pnpm run build --watch

Reproduce link

none, just every clean default code

Reproduce Steps

1. init ptoject
2. add a plugin with afterBuild hook and console.log('here i am running')
3. pnpm run build --watch

expect run everytime when i change the src/index.ts code like hello world 2

[Timeless0911]

When in watch mode, the dts build sub task is implemented by running tsc --watch in a sub process, the watch command doesn't have a terminated state, so we can not get when this sub task ended. Therefore, afterBuild task will not be executed when in watch mode with dts build sub task.

You can do something in afterBuildTask hook instead, and use options.config.format to judge whether it's esm build sub task or cjs.

[FeSeason]

+1

[Timeless0911]

rebuild has other hooks which not be written in docs, you can use buildWatchJs hook when before rebuild

code logic is as below:

modern.js/packages/solutions/module-tools/src/hooks/build.ts

Lines 36 to 39 in 7ed2fbc

	export const buildWatchHooks = {
	buildWatchJs: createParallelWorkflow<WatchJsHookContext, void>(),
	buildWatchDts: createParallelWorkflow<WatchDtsHookContext, void>(),
	};

modern.js/packages/solutions/module-tools/src/builder/esbuild/watch.ts

Lines 65 to 76 in 7ed2fbc

	const handleChange = async (filePath: string, _events: Stats) => {
	const {
	context: { root },
	watchedFiles,
	} = compiler;
	if (watchedFiles.has(path.resolve(root, filePath))) {
	logger.info(`File changed: ${chalk.dim(filePath)}`);
	const runner = api.useHookRunners();
	runner.buildWatchJs({ buildConfig: config });
	await compiler.reBuild('change', config);
	}
	};