Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Pass vm.Labels to runtime containers #852

Open
networkop opened this issue Jul 2, 2021 · 2 comments
Open

Pass vm.Labels to runtime containers #852

networkop opened this issue Jul 2, 2021 · 2 comments
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature.

Comments

@networkop
Copy link
Contributor

networkop commented Jul 2, 2021

Right now VM labels only exist on a VM itself. The only label that's propagated to the containers is ignite.name
https://github.com/weaveworks/ignite/blob/main/pkg/operations/start.go#L77

It'd be nice to propagate the full set of labels to the underlying container as well. wdyt?

@darkowlzz
Copy link
Contributor

Sounds good to me. We'll have to add some validation in the labels to prevent the user provided VM labels from overwriting the ignite set labels like ignite.name.

@darkowlzz darkowlzz added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Jul 4, 2021
@stealthybox
Copy link
Contributor

Notable that k8s api machinery dictates labels be dns-1123 subdomains.
That means that labels should be small and in a fairly restricted schema that should be compatible with most or all container runtimes.
(currently, docker and containerd are supported by ignite.)

Should be okay to just pass down all VM labels to container runtime, with the exception of ignite runtime necessities like ignite.name.

This lets ignite propagate user-created partitions in their VM workloads into the container runtime, which can make cleanup and debugging more comprehensible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants