Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail-fast? not working #75

Open
rutchkiwi opened this issue Nov 7, 2019 · 0 comments
Open

fail-fast? not working #75

rutchkiwi opened this issue Nov 7, 2019 · 0 comments

Comments

@rutchkiwi
Copy link

rutchkiwi commented Nov 7, 2019 •
edited

Hi. First of all, thank you for providing this awesome library, it has been a life saver for my team!

I can't seem to get the fail-fast? option to work when running tests from the repl like this:

(eftest/run-tests (eftest/find-tests "test")
                    {:multithread?    false
                     :report          eftest.report.pretty/report
                     :capture-output? true
                     :test-warn-time  500
                     :fail-fast?      true})

With this config, when a test fails it keeps going running all of them!

Getting this working would help me a lot, as running all my tests takes quite a long time when something funamental breaks (because so many errors are printed to the REPL).

Am I doing something wrong, or is this a real issue? I'm using [eftest "0.5.9"]

=== edit: Upgraded to 0.5.9 and the problem persists
vemv added a commit to reducecombine/eftest that referenced this issue Oct 7, 2021
@vemv
Increase test coverage for :fail-fast?
f518982 
This will help reliably coming up with a fix for weavejester#75.

Coverage is extended by:

* providing counterexamples to each test case
* also exercising exception handling, whether it happens in the deftest body, or in fixtures.
@vemv vemv mentioned this issue Oct 7, 2021
Open
vemv added a commit to reducecombine/eftest that referenced this issue Oct 19, 2021
@vemv
Increase test coverage for :fail-fast?
7cb3632 
This will help reliably coming up with a fix for weavejester#75.

Coverage is extended by:

* providing counterexamples for each test case
* also exercising exception handling, whether it happens in the deftest body, or in fixtures.
vemv added a commit to reducecombine/eftest that referenced this issue Oct 22, 2021
@vemv
Increase test coverage for :fail-fast?
9f31168 
This will help reliably coming up with a fix for
weavejester#75.

Coverage is extended by:

* providing counterexamples for each test case
* also exercising exception handling, whether it happens in the deftest
body, or in fixtures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rutchkiwi