Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interoperabiliity between duplicate copies of redux-components library in a bundle #6

Open
wcjohnson opened this issue Mar 12, 2017 · 0 comments
Labels

Comments

@wcjohnson
Copy link
Owner

In large builds, multiple packages may depend on redux-components. This can cause duplicate copies to end up in a webpack bundle.

This, in turn, causes multiple instances of key objects like the ReduxComponent base class, which causes instanceof() to fail to properly detect ReduxComponents that come from another copy of the library.

The ultimate manifestation of this is cannot mount something that isn't an instance of ReduxComponent errors in dev invariant mode.

We should consider storing critical information on a global object, or perhaps using something like React 15's $$typeof symbol.

@wcjohnson wcjohnson added the bug label Mar 12, 2017
@wcjohnson wcjohnson changed the title Interoperabiliity between duplicate copies of redux-components Interoperabiliity between duplicate copies of redux-components library in a bundle Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant