Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_bindFinish fails on Firefox #24

Open
dleffler opened this issue Jun 3, 2013 · 2 comments
Open

_bindFinish fails on Firefox #24

dleffler opened this issue Jun 3, 2013 · 2 comments

Comments

@dleffler
Copy link

dleffler commented Jun 3, 2013

With v1.1.0 under Firefox, if the option finishButton is true, then the _bindFinish method is called... however the var finish won't be assigned to the 'submit' button, line #132

finish = that.children('input[type="submit"]');

finish will be set to null, but a jQuery alternative is

finish = $(':submit',that);

@wbotelhos
Copy link
Owner

Try to change to .find().
Maybe the button is inside another container and it's not a children.
But, it should be a children, than let me know why it is not.

@dleffler
Copy link
Author

dleffler commented Jun 3, 2013

Yes every form ‘control’ is inside its own

since this is a programmatically generated form for a cms. I’ll probably just lean toward a locally customized version of stepy, e.g., having a ‘body’ style in the stepy jquery plugin tends to mess with the overall page styling.

Thanks for the good work!

Dave Leffler

From: Washington Botelho [mailto:notifications@github.com]
Sent: Monday, June 03, 2013 10:43 AM
To: wbotelhos/stepy
Cc: dleffler
Subject: Re: [stepy] _bindFinish fails on Firefox (#24)

Try to change to .find().
Maybe the button is inside another container and it's not a children.
But, it should be a children, than let me know why it is not.


Reply to this email directly or view it on GitHub #24 (comment) .Image removed by sender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants