Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel button does not work with touchscreen input #44

Open
sado1 opened this issue Nov 12, 2021 · 5 comments
Open

Panel button does not work with touchscreen input #44

sado1 opened this issue Nov 12, 2021 · 5 comments

Comments

@sado1
Copy link

sado1 commented Nov 12, 2021

Hello. I'm running Fedora 35, Gnome 41 - I was glad to see this plugin, as it's really cool for my usecase (convertible laptop with touch input, combined with inability to use push-to-talk in TeamSpeak on Wayland). But it seems that I can only click the panel button to enable/disable microphone (using touchpad). Touching the button via touchscreen has no effect, other than the long press turns the button's background to grey. Could you please try to make the touch input work as well? If any more information would be helpful, please let me know.

@wbolster
Copy link
Owner

i agree this would be useful but tbh i have no idea what the technical solution is to make this work.

@sado1
Copy link
Author

sado1 commented Mar 12, 2022

When I changed:
this.connect("button-press-event", () => {
to
this.connect("touch-event", () => {
it somewhat works. You need to move your finger constantly, then it keeps working as 'hold to talk', if you stop your finger, sometimes the extension thinks, that the button is being constantly being enabled and disabled in a loop.

I have little understanding of how Gnome extensions work, but after looking at the docs, I guess that the touch event emits the signal for multiple actions, which is not what we want here. We only want to detect initially touching the button - and, if we want to have a push-to-talk option - when we stop touching it, too.

I'll be glad for any hints, I imagine you don't have access to hardware with Gnome and touchscreen, I can take a look at fixing this.

@BenignBeppe
Copy link
Collaborator

I did a quick test on my touch screen and it works just like clicking. This is on Ubuntu 20.04.

@wbolster
Copy link
Owner

do you mean the current button-press-event works for you, @BenignBeppe?

@BenignBeppe
Copy link
Collaborator

Yes. Maybe there is some difference in implementation with touch, so for me it works exactly like a mouse click, but that not always being the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants