Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong assignment to Q inside the HistoryEmbedded? #7

Open
marimeireles opened this issue Mar 24, 2024 · 2 comments
Open

Wrong assignment to Q inside the HistoryEmbedded? #7

marimeireles opened this issue Mar 24, 2024 · 2 comments

Comments

@marimeireles
Copy link
Collaborator

For the following configuration:
Screenshot 2024-03-24 at 4 25 01 PM

The result of self.Q is 2.

Why is the length of observations equals 2? Shouldn't it be 4?
@marimeireles marimeireles changed the title Wrong assignment to Q inside the HIstoryEmbedded? Wrong assignment to Q inside the HistoryEmbedded? Mar 24, 2024
@marimeireles
Copy link
Collaborator Author

It doesn't seem like self.Q is being used anywhere else in the HistoryEmbedded code nor in the agent classes that work with it.

@marimeireles
Copy link
Collaborator Author

Fix and add a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marimeireles