New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agents are not being restarted after manager change in E2E vulnerability detection tests #5355
Merged
juliamagan
merged 10 commits into
4.8.0
from
fix/5345-skip-truncate-test-change-agent-manager
May 13, 2024
Merged
Agents are not being restarted after manager change in E2E vulnerability detection tests #5355
juliamagan
merged 10 commits into
4.8.0
from
fix/5345-skip-truncate-test-change-agent-manager
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santipadilla
force-pushed
the
fix/5345-skip-truncate-test-change-agent-manager
branch
from
May 9, 2024 14:09
6a5caa6
to
ff13f5c
Compare
rafabailon
previously approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliamagan
requested changes
May 10, 2024
santipadilla
changed the title
Skip truncate test change agent manager
Agents are not being restarted after manager change in E2E vulnerability detection tests
May 13, 2024
Rebits
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliamagan
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the restart of the agents in
test_change_agent_manager
case.