Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTT2 - The workflow engine log format differs from the other modules' log format. #5286

Open
mhamra opened this issue Apr 23, 2024 · 0 comments

Comments

@mhamra
Copy link
Member

mhamra commented Apr 23, 2024

Target version Related issue Related PR/dev branch
4.9.0 4495-dtt1-release

The log format used by the modules differs. The workflow_engine log format is the following:

formatters:
simple:
format: '[%(asctime)s] [%(levelname)s] [%(process)d] [%(threadName)s] [%(name)s]: %(message)s'
colored:
(): colorlog.ColoredFormatter
format: '%(log_color)s[%(asctime)s] [%(levelname)s] [%(process)d] [%(threadName)s] [%(name)s]: %(message)s'

The other modules use this format:

formatters:
simple:
format: '[%(asctime)s] [%(levelname)s] %(name)s: %(message)s'
colored:
(): colorlog.ColoredFormatter
format: '%(log_color)s[%(asctime)s] [%(levelname)s] %(name)s: %(message)s'

The desired format must be the first; the modules called from the workflow must receive the process and thread name to generate the desired format.

I suggest improving the log file format by adding the task name of the workflow.

We also need to add to the console output which module is executing the task, this is reported in the log file but not in the console output

image

@rauldpm rauldpm changed the title DTT1. The workflow engine log format differs from the other modules' log format. DTT2 - The workflow engine log format differs from the other modules' log format. Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants