Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve versioning of upstream's configuration files #94

Open
Tracked by #110
AlexRuiz7 opened this issue Dec 26, 2023 · 0 comments
Open
Tracked by #110

Improve versioning of upstream's configuration files #94

AlexRuiz7 opened this issue Dec 26, 2023 · 0 comments
Labels
level/task Task issue request/operational Operational requests type/enhancement Enhancement issue

Comments

@AlexRuiz7
Copy link
Member

Description

To generate the packages, we needed to include some files from upstream (opensearch-build repository). Some of these files have been modified significantly enough to justify keeping them in the wazuh-indexer repository. However, many of these files are minimally modified or not modified at all. For these files, we would have to find an alternative other than versioning them ourselves, as that would mean having to track upstream's changes to them and reconcile their changes with ours on each version.

The best alternative would be to download those files from the appropriate version of OpenSearch during the wazuh-indexer package build process, and then apply whatever modifications are necessary to them (in most cases it's just adding a few lines of code or some renaming). In this way, we benefit from the changes applied from upstream without them conflicting with our own, and without having to perform the versioning of these files.

Most of these files are related to the security plugin.

  • distribution/src/config/jvm.prod.options
  • distribution/src/config/security/action_groups.yml
  • distribution/src/config/security/internal_users.yml
  • distribution/src/config/security/roles.yml
  • distribution/src/config/security/roles_mapping.yml

Hosting these files are justified due to the amount of changes, but could be taken into account as well:

  • distribution/packages/src/rpm/wazuh-indexer-performance-analyzer.service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue request/operational Operational requests type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

1 participant