Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wazuh Cloud - Add Canada Region #7145

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

sultanovich
Copy link
Member

Description

This PR adds Canada Region on Wazuh Cloud.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

Copy link
Member

@dariommr dariommr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sultanovich
Copy link
Member Author

Hi @javimed , Could you check this PR? This change includes Canada in the regions available to apply for environments in Wazuh cloud.

Thanks,

@javimed
Copy link
Member

javimed commented Mar 27, 2024

@sultanovich I can see that for each region we're referring in the way you can see highlighted in the following images:

imagen
imagen
imagen

However, in this PR we're referring in the way highlighted below.

imagen

This doesn't look consistent. Are we ok with it? Why not using the full region names in the way AWS does?

@javimed javimed self-requested a review March 27, 2024 12:26
Copy link
Member

@javimed javimed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@sultanovich
Copy link
Member Author

Hi @javimed , is correct what you indicate. The problem is that we have been using part of the name of the AWS regions to identify them in the documentation, but in the case of the new region in Canada central I'm not sure if it will be clear to the customer.

image

It would be best to use the full name as described by AWS.

image

I am consulting internally to confirm how we want to apply the change, as soon as I have an answer I will update it here.

@sultanovich
Copy link
Member Author

Hi @javimed , we have defined to move forward with this modification as proposed.
We are preparing a new change later to standardize the documentation so that all regions are identified in the same way. As soon as it is ready we will send it as a new PR for your review.

@javimed
Copy link
Member

javimed commented May 7, 2024

Hi @sultanovich . A second read of this comment now makes me think you want to merge this PR in the way it is now without addressing the consistency concerns I mentioned above. Please link the issue where it's planned to make these changes.

@javimed javimed merged commit 3701a9b into 4.7 May 7, 2024
3 checks passed
@javimed javimed deleted the wazuh-cloud-add-canada-region branch May 7, 2024 11:14
@javimed javimed linked an issue May 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No consistency in AWS region references
3 participants