New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wazuh Cloud - Add Canada Region #7145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @javimed , Could you check this PR? This change includes Canada in the regions available to apply for environments in Wazuh cloud. Thanks, |
@sultanovich I can see that for each region we're referring in the way you can see highlighted in the following images: However, in this PR we're referring in the way highlighted below. This doesn't look consistent. Are we ok with it? Why not using the full region names in the way AWS does? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
Hi @javimed , is correct what you indicate. The problem is that we have been using part of the name of the AWS regions to identify them in the documentation, but in the case of the new region in Canada It would be best to use the full name as described by AWS. I am consulting internally to confirm how we want to apply the change, as soon as I have an answer I will update it here. |
Hi @javimed , we have defined to move forward with this modification as proposed. |
Hi @sultanovich . A second read of this comment now makes me think you want to merge this PR in the way it is now without addressing the consistency concerns I mentioned above. Please link the issue where it's planned to make these changes. |
Description
This PR adds Canada Region on Wazuh Cloud.
Checks
Docs building
Code formatting and web optimization
redirects.js
script if necessary (check this guide).Writing style
code
font for Bash commands, file names, REST paths, and code.