Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve behavior about send messages through a socket #75

Open
thejbte opened this issue Dec 22, 2023 · 0 comments
Open

improve behavior about send messages through a socket #75

thejbte opened this issue Dec 22, 2023 · 0 comments
Assignees

Comments

@thejbte
Copy link
Contributor

thejbte commented Dec 22, 2023

Problem:

The send_active_response_message function is not needed, you can use send_request_socket. On the other hand, in the send_message_to_syslog_socket function use the SocketController class as done in send_request_socket so the import socket is not needed (delete it).

  • The SocketController class only allows TCP connections and send_active_response_message receives UDP and also waits for a response
  • Test if ManInTheMiddle does the SocketController thing in a better way and is already used in the framework
  • Fix tests that use send_active_response_message and send_message_to_syslog_socket in test_remoted
@thejbte thejbte self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant