Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance stateChangesById for sponsored transactions #2649

Open
deemru opened this issue Oct 4, 2019 · 3 comments
Open

Enhance stateChangesById for sponsored transactions #2649

deemru opened this issue Oct 4, 2019 · 3 comments
Assignees
Labels

Comments

@deemru
Copy link
Member

deemru commented Oct 4, 2019

Аbstract
Currently there is no trivial way to get how much WAVES sponsor pays for his sponsored asset in fees in transactions.

Motivation and Purposes
It hard to maintain the state of sponsorships database, lets use stateChangesById in the way you did for invoke script transactions.

Specification
Enhance GET /debug/stateChanges/info/{id} where sponsored asset is used for a fee to get stateChanges as how much WAVES was really paid in exchange for sponsored asset.

@deemru deemru added the feature label Oct 4, 2019
@phearnot phearnot changed the title [FEATURE] Enhance stateChangesById for sponsored transactions Enhance stateChangesById for sponsored transactions Oct 16, 2019
@pivoo81
Copy link
Member

pivoo81 commented Nov 15, 2019

Hi Dmitry!
Ability to give such information is connected to storing additional data in the nodes DB. Which is not needed in most cases.
Maybe we implement it later with some optional node extension.

@deemru
Copy link
Member Author

deemru commented May 28, 2020

We already have:

waves.db.store-transactions-by-address = true
waves.db.store-invoke-script-results = true

Sponsored transactions for now are ok, but when you will implement WEP 2 it would be necessary to have this option.

@pivoo81
Copy link
Member

pivoo81 commented Jun 2, 2020

We don't want to implement it in the Node, maybe it should be available in data-service, now thinking about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants