Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string representations for procedures classes #43

Open
jacobdeery opened this issue Jun 25, 2020 · 6 comments · May be fixed by #54
Open

Add string representations for procedures classes #43

jacobdeery opened this issue Jun 25, 2020 · 6 comments · May be fixed by #54
Assignees
@Kenttrann2302
Labels
enhancement New feature or request good first issue Good for newcomers procedures Affects procedures or ProcLang code

Comments

@jacobdeery
Copy link
Contributor

We haven't defined __str__ methods for Action, Transition, Step, Procedure, or any of the condition classes, which means that when we print them we get things like this:

<topside.procedures.conditions.GreaterEqual object at 0x0000024844702688>

Action(component='c1', state='open')

ProcedureStep(step_id='s1', action=None, conditions={<topside.procedures.conditions.Immediate object at 0x0000024815FC2748>: Transition(procedure='p1', step='s2')})

Procedure(procedure_id='p1', steps={'s1': ProcedureStep(step_id='s1', action=None, conditions={<topside.procedures.conditions.Immediate object at 0x0000024815FC2748>: Transition(procedure='p1', step='s2')}), 's2': ProcedureStep(step_id='s2', action=Action(component='c1', state='open'), conditions={<topside.procedures.conditions.Immediate object at 0x0000024844DA0448>: Transition(procedure='p1', step='s3')}), 's3': ProcedureStep(step_id='s3', action=Action(component='c1', state='closed'), conditions={})})

This isn't wrong, but when we want to add logging it will definitely be more convenient to have string representations so that it's easier to read.
@jacobdeery jacobdeery added the good first issue Good for newcomers label Jun 25, 2020
@Aditya1001001
Copy link

I want to work on this issue, can you assign it to me?

@jacobdeery
Copy link
Contributor Author

Hello @Aditya1001001 - typically we only assign issues to Waterloo Rocketry team members. Are you a member of the team?

@Aditya1001001
Copy link

@jacobdeery I'm afraid I'm not a member of the team. Can you still assign it to me?

@jacobdeery
Copy link
Contributor Author

jacobdeery commented Jun 25, 2020 •
edited

@Aditya1001001 - Right now Topside is still in its early stages and we would like to save these issues as opportunities for newer team members to become familiar with the project. Thank you for your interest, though!

@Aditya1001001
Copy link

@jacobdeery that's a bit disappointing. I'll just watch the repo for now.

@x-jesse
Copy link

x-jesse commented Aug 6, 2020

Hi @jacobdeery, I'm interested in working on this issue. Can you assign it to me?

@jacobdeery jacobdeery added procedures Affects procedures or ProcLang code enhancement New feature or request labels Sep 19, 2020
@jacobdeery jacobdeery linked a pull request Sep 19, 2020 that will close this issue
Add string representation for the procedures classes #54
Open
@Kenttrann2302 Kenttrann2302 self-assigned this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kenttrann2302 Kenttrann2302

Labels
enhancement New feature or request good first issue Good for newcomers procedures Affects procedures or ProcLang code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add string representation for the procedures classes waterloo-rocketry/topside
4 participants
@jacobdeery @Aditya1001001 @x-jesse @Kenttrann2302