Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to talk updates #21

Open
ChristinaB opened this issue Sep 18, 2020 · 2 comments
Open

need to talk updates #21

ChristinaB opened this issue Sep 18, 2020 · 2 comments

Comments

@ChristinaB
Copy link

@emiliom - could you proofread and let me know where you want to add this file? https://github.com/waterhackweek/learning-resources/blob/master/docs/canaryopera/need_to_talk_to_someone.md

@ChristinaB
Copy link
Author

I did commit directly to master but I can do a PR if you want and edit the index

@emiliom
Copy link
Collaborator

emiliom commented Sep 23, 2020

@ChristinaB this is an out-of-the-blue page. In the future you need to tell me exactly where you want it in the structure of the site; otherwise I'm just second guessing your intent, and that's more work for me. Ideally if you're going to be creating new pages and moving existing ones around, please familiarize yourself with site development using mkdoc so you can do everything yourself on your computer, including testing your changes, before submitting the pull request. See instructions on the README file.

I went ahead and added your page under "Overview" in order to implement this now, and b/c I couldn't think of any other location.

I'm sorry, but this new page is way too big for me to offer to do proofreading. In general, please have others proofread your content.

And yes, please submit changes only via pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants