New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wasmi execution profiling infrastructure #974
Draft
Robbepop
wants to merge
20
commits into
master
Choose a base branch
from
rf-add-profiling-infra
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #974 +/- ##
==========================================
- Coverage 81.87% 81.65% -0.23%
==========================================
Files 260 263 +3
Lines 23904 23971 +67
==========================================
+ Hits 19572 19573 +1
- Misses 4332 4398 +66 ☔ View full report in Codecov by Sentry. |
We need this to guard against Instruction::Return which turns into return which is a Rust keyword.
- Now uses a single Ticker instead of one StopWatch per instruction - Adds the new instruction selection API - Now generates a new-type wrapping ProfilingData instead of re-using the generic ProfilingData directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #973.
enum
.profiling
crate feature.profiling
crate feature.profiling
crate feature.profiling
crate feature.This should provide better and more versatile information than a flamegraph.