Merge copy instructions if possible #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fixing a potential issue when merging copy instructions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 81.77% 81.81% +0.03%
==========================================
Files 262 263 +1
Lines 24378 24426 +48
==========================================
+ Hits 19936 19984 +48
Misses 4442 4442 ☔ View full report in Codecov by Sentry. |
|
The |
|
I just checked locally if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #946.
This merges two
copyinstructions to acopy2instruction if possible.Locally I saw ~20% perf improvement for the
fibonacci/iterbenchmark test case which actually profits from this optimization since it features 2 consecutive(local.set n (local.get m))in its.watcode: