Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistakenly computing hash of a pre-compiled artifact #4632

Closed
linear bot opened this issue Apr 30, 2024 · 0 comments
Closed

Mistakenly computing hash of a pre-compiled artifact #4632

linear bot opened this issue Apr 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@linear
Copy link

linear bot commented Apr 30, 2024

We are mistakenly computing the hash of a pre-compiled artifact as a ModuleHash here:

TargetOnDisk::Artifact => {
let engine = runtime.engine();
pb.set_message("Deserializing pre-compiled WebAssembly module");
let module = unsafe { Module::deserialize_from_file(&engine, path)? };
let module_hash = {
let wasm = std::fs::read(path)?;
ModuleHash::hash(wasm)
};

The hash probably should be included in the CompiledModule info.

@linear linear bot added the bug Something isn't working label Apr 30, 2024
@linear linear bot closed this as completed May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants