feat: Instance Imports #11

syrusakbary · 2020-01-30T03:57:13Z

We should be able to pass imports to when instantiating a WebAssembly module, so the wasm code can call the host java functions and use their results.

syrusakbary · 2020-05-14T15:58:42Z

This is resolved in master. Closing the issue

syrusakbary · 2020-05-14T15:58:57Z

(got confused about exports, reopening)

BlakeB415 · 2020-05-21T21:50:14Z

+1 would be super useful!

sigmasoldi3r · 2020-05-26T14:14:48Z

Agree! Is there any workaround?

syrusakbary · 2020-05-27T19:02:56Z

We are working on a small refactor that will enable this very easily.

BlakeB415 · 2020-10-02T03:57:16Z

Any updates?

syrusakbary · 2020-10-02T06:33:17Z

The refactor is now publicly available (wasmer 1.0.0-alpha). We just need to update the bindings :)

SuperIceCN · 2020-11-29T14:42:58Z

@syrusakbary Can I call the host java functions and use their results from wasm code now? If so, could you tell me how to do? Thanks!

Hywan · 2020-11-30T13:02:51Z

Host functions aren't supported yet. We are going to work on it :-).

SuperIceCN · 2021-01-15T12:33:03Z

Will host funtions be supported in 2021?

Hywan · 2021-03-02T12:57:18Z

In 2021 for sure! I hope in a couple of weeks :-).

roee88 · 2021-05-05T06:42:55Z

@Hywan is this being worked on? We're particularly interested in using it for memory import

jcaesar · 2021-09-05T08:48:40Z

I had a bit of a go at implementing: https://github.com/jcaesar/wasmer-java/compare/wasmer-2...jcaesar:imports?expand=1
I can't test it because gradle, so I don't expect it to work as is.

In all honesty, wasmer-java needs a rewrite, and one without the jni crate. That's an unwinnable game of catchup with glue code of dubious safety.

ripSquid · 2022-01-22T23:00:20Z

Any new info on this?

SuperIceCN · 2022-01-26T00:32:21Z

In 2021 for sure! I hope in a couple of weeks :-).

@Hywan Hello, now it's 2022.

jcaesar · 2022-01-26T00:56:06Z

Ivan quit working for wasmerio 4 months ago. ;)

sigmasoldi3r · 2022-01-27T10:45:50Z

oh dear :v
@jcaesar does this mean that this feature is frozen?

jcaesar · 2022-01-28T01:47:46Z

Well, don't ask me… but I assume it's way down the list. If someone implemented it and made a PR (well, or finished my code), I assume it would get merged and released. [Edit:] Well, who knows, it might not. The releases were on bintray after all. Nobody has taken care of that either.

beaclnd · 2022-02-20T08:12:10Z

@jcaesar I have finished your code and made a PR #64.

EXEC-CSM · 2022-03-14T08:46:04Z

@beaclnd92 I do a windows build of your PR. It runs without any errors.
But if I run my java app I got the following exception:

Exception in thread "main" java.lang.UnsatisfiedLinkError: 'long org.wasmer.Imports.nativeImportsWasi()'
at org.wasmer.Imports.nativeImportsWasi(Native Method)
at org.wasmer.Imports.wasi(Imports.java:90)

I want to run the mappings.wasm from https://github.com/mozilla/source-map/blob/master/lib/mappings.wasm

import java.io.IOException;
import java.io.InputStream;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

import org.apache.commons.io.IOUtils;
import org.wasmer.Exports;
import org.wasmer.Imports;
import org.wasmer.Imports.Spec;
import org.wasmer.Instance;
import org.wasmer.Module;
import org.wasmer.Native;

public class WASM
{
	public static void main(String[] args)
	{
		new WASM();
	}
	
	public class WASMMapping
	{
		public int generatedLine = 0;
		public int generatedColumn = 0;
		public Integer lastGeneratedColumn = null;
		public String source = null;
		public Integer originalLine = null;
		public Integer originalColumn = null;
		public String name = null;
	}

	public Exports exports;
	private Instance wasm;

	public WASM()
	{
		init();
	}

	private void init()
	{
		byte[] moduleBytes;
		try (InputStream is = this.getClass().getResourceAsStream("mappings.wasm");)
		{
			moduleBytes = IOUtils.toByteArray(is);
			String platform = Native.getCurrentPlatformIdentifier();
			System.out.println(platform);

			/** https://github.com/beaclnd92/wasmer-java/tree/imports/src/java/org/wasmer */
			if (Module.validate(moduleBytes))
			{
				Module m = new Module(moduleBytes);

				List<Spec> specImpList = new ArrayList<>();
				/** https://github.com/mozilla/source-map/blob/master/lib/wasm.js */
				Spec spec = new Spec("env", "mapping_callback", new java.util.function.Function<List<Number>, List<Number>>() {

					@Override
					public List<Number> apply(List<Number> t)
					{
						WASMMapping mapping = new WASMMapping();
						t.forEach(e -> System.out.println(e));

						return Collections.emptyList();
					}

				}, Collections.emptyList(), Collections.emptyList());
				specImpList.add(spec);

				Imports imp = Imports.from(specImpList, 0);
				this.wasm = m.instantiate(imp);
				this.exports = this.wasm.exports;
			}
		}
		catch (IOException e)
		{
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
	}
}

When I use the code above I got a java runtime error:

windows-amd64
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007ffc6bb1b1a3, pid=36420, tid=5736
#
# JRE version: OpenJDK Runtime Environment (11.0.6+10) (build 11.0.6+10-LTS)
# Java VM: OpenJDK 64-Bit Server VM (11.0.6+10-LTS, mixed mode, tiered, compressed oops, g1 gc, windows-amd64)
# Problematic frame:
# C  [wasmer_jni12599045650012626710.lib+0x1b1a3]
#
# No core dump will be written. Minidumps are not enabled by default on client versions of Windows
#

# An error report file with more information is saved as:
# D:\app\hs_err_pid36420.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

hs_err_pid36420.log

Any help appreciated
Thanks

EXEC-CSM · 2022-03-14T10:08:07Z

Think I have unterstand how to use it. ...

import java.io.IOException;
import java.io.InputStream;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

import org.apache.commons.io.IOUtils;
import org.wasmer.Exports;
import org.wasmer.Imports;
import org.wasmer.Imports.Spec;
import org.wasmer.Instance;
import org.wasmer.Module;
import org.wasmer.Native;
import org.wasmer.Type;

public class WASM extends Module
{
	public static void main(String[] args)
	{
		new WASM();
	}

	static byte[] moduleBytes;

	static
	{
		try (InputStream is = WASM.class.getResourceAsStream("mappings.wasm");)
		{
			moduleBytes = IOUtils.toByteArray(is);
		}
		catch (IOException e)
		{
			e.printStackTrace();
		}
	}

	public class WASMMapping
	{
		public int generatedLine = 0;
		public int generatedColumn = 0;
		public Integer lastGeneratedColumn = null;
		public String source = null;
		public Integer originalLine = null;
		public Integer originalColumn = null;
		public String name = null;
	}

	public Exports exports;
	private Instance wasm;

	public WASM()
	{
		super(WASM.moduleBytes);
		init();
	}

	private void init()
	{
		String platform = Native.getCurrentPlatformIdentifier();
		System.out.println(platform);

		// https://github.com/beaclnd92/wasmer-java/tree/imports/src/java/org/wasmer
		if (Module.validate(moduleBytes))
		{
//				Module m = new Module(moduleBytes);
			List<Type> typeList = new ArrayList<>();
			for (int t = 0; t < 10; t++)
				typeList.add(Type.I32);

			List<Spec> specImpList = new ArrayList<>();
			// https://github.com/mozilla/source-map/blob/master/lib/wasm.js
			Spec spec = new Spec("env", "mapping_callback", new java.util.function.Function<List<Number>, List<Number>>() {

				@Override
				public List<Number> apply(List<Number> t)
				{
					WASMMapping mapping = new WASMMapping();
					t.forEach(e -> System.out.println(e));

//						// JS uses 1-based line numbers, wasm uses 0-based.
//						mapping.generatedLine = generatedLine + 1;
//						mapping.generatedColumn = generatedColumn;
//
//						if (hasLastGeneratedColumn)
//						{
//							// JS uses inclusive last generated column, wasm uses exclusive.
//							mapping.lastGeneratedColumn = lastGeneratedColumn - 1;
//						}
//
//						if (hasOriginal)
//						{
//							mapping.source = source;
//							// JS uses 1-based line numbers, wasm uses 0-based.
//							mapping.originalLine = originalLine + 1;
//							mapping.originalColumn = originalColumn;
//
//							if (hasName)
//							{
//								mapping.name = name;
//							}
//						}

//			            callbackStack[callbackStack.length - 1](mapping);
//						// TODO Auto-generated method stub
					return Collections.emptyList();
				}

			}, typeList, Collections.emptyList());
			specImpList.add(spec);

			Imports imp = Imports.from(specImpList, this.modulePointer);
			this.wasm = this.instantiate(imp);
			this.exports = this.wasm.exports;
		}
//		}
//		catch (IOException e)
//		{
//			// TODO Auto-generated catch block
//			e.printStackTrace();
//		}
	}
}

beaclnd · 2022-03-16T06:00:20Z

@EXEC-CSM I just recognized it's inconvenient to use，so I have fixed the implementation. We can use it like below：

Module m = new Module(moduleBytes);
Imports imp = Imports.from(specImpList, m);
Instance i = m.instantiate(imp);

i059917 · 2022-05-05T02:29:28Z

Hello, any update of this? Will Import support function be released with next version? @beaclnd92
Btw, is there anyone can teach me how to build @beaclnd92's PR on Mac locally, maybe I can play around with it :). Thanks.

cafebabe · 2022-05-09T13:30:36Z

Hi @i059917, while waiting for this to be merged I've been successfully able to develop using imports on beaclnd92's work on Mac, works really well. Seems as simple as cloning beaclnd92 repo and checking out the imports branch.

git clone https://github.com/beaclnd92/wasmer-java
cd wasmer-java
git checkout imports

make then creates you the wasmer-jni-amd64-darwin-0.3.0.jar you need (following same instructions as for wasmer-java build). I did find I needed to run using -Dos.arch=amd64 on the JVM for it to find the JNI bindings though.

jcaesar · 2022-05-10T08:09:55Z

I somehow doubt wasmer-java is still anywhere on wasmerio's priority list… Might be best if someone with vested interest (I no longer have) forked this and put it onto Maven Central, or so?

Hywan · 2022-05-10T11:37:08Z

cc @syrusakbary

syrusakbary · 2022-05-10T23:10:54Z

I somehow doubt wasmer-java is still anywhere on wasmerio's priority list

We are prioritizing a refactor of Wasmer at the moment, but meanwhile will welcome any contributions from the community.
Wasmer-Java as of right now has to be updated with the latest Wasmer API, as of now it's using the 0.x API.

This Wasmer JNI bindings were using the latest API afaik:
https://github.com/Salpadding/wasmer-jni

jcaesar · 2022-05-13T11:41:37Z

https://github.com/Salpadding/wasmer-jni

Neat, that even supports instance imports.

xjq7 · 2023-08-21T03:25:23Z

@EXEC-CSM I would also like to run mappings.wasm in the Java source gallery. Did you get it to work?

syrusakbary added the 🎉 enhancement New feature or request label Jan 30, 2020

Hywan added this to 🏁 Ready in Kanban Feb 13, 2020

syrusakbary closed this as completed May 14, 2020

Kanban automation moved this from 🏁 Ready to 🎉 Done May 14, 2020

syrusakbary reopened this May 14, 2020

Kanban automation moved this from 🎉 Done to 🌱 In progress May 14, 2020

Hywan mentioned this issue Nov 30, 2020

Add support for WASM imports #44

Closed

robertesler mentioned this issue Dec 27, 2020

Error when instantiating WASM files built from C/C++ #45

Open

jcaesar mentioned this issue Jan 28, 2022

Bump up WASI version to enable "wasi-snapshot-preview1"."proc_exit" #63

Closed

beaclnd mentioned this issue Feb 20, 2022

Imports #64

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Instance Imports #11

feat: Instance Imports #11

syrusakbary commented Jan 30, 2020 •

edited

syrusakbary commented May 14, 2020

syrusakbary commented May 14, 2020

BlakeB415 commented May 21, 2020

sigmasoldi3r commented May 26, 2020

syrusakbary commented May 27, 2020

BlakeB415 commented Oct 2, 2020

syrusakbary commented Oct 2, 2020

SuperIceCN commented Nov 29, 2020

Hywan commented Nov 30, 2020

SuperIceCN commented Jan 15, 2021

Hywan commented Mar 2, 2021

roee88 commented May 5, 2021

jcaesar commented Sep 5, 2021

ripSquid commented Jan 22, 2022

SuperIceCN commented Jan 26, 2022 •

edited

jcaesar commented Jan 26, 2022

sigmasoldi3r commented Jan 27, 2022

jcaesar commented Jan 28, 2022 •

edited

beaclnd commented Feb 20, 2022 •

edited

EXEC-CSM commented Mar 14, 2022 •

edited

EXEC-CSM commented Mar 14, 2022 •

edited

beaclnd commented Mar 16, 2022

i059917 commented May 5, 2022 •

edited

cafebabe commented May 9, 2022

jcaesar commented May 10, 2022

Hywan commented May 10, 2022

syrusakbary commented May 10, 2022

jcaesar commented May 13, 2022

xjq7 commented Aug 21, 2023

feat: Instance Imports #11

feat: Instance Imports #11

Comments

syrusakbary commented Jan 30, 2020 • edited

syrusakbary commented May 14, 2020

syrusakbary commented May 14, 2020

BlakeB415 commented May 21, 2020

sigmasoldi3r commented May 26, 2020

syrusakbary commented May 27, 2020

BlakeB415 commented Oct 2, 2020

syrusakbary commented Oct 2, 2020

SuperIceCN commented Nov 29, 2020

Hywan commented Nov 30, 2020

SuperIceCN commented Jan 15, 2021

Hywan commented Mar 2, 2021

roee88 commented May 5, 2021

jcaesar commented Sep 5, 2021

ripSquid commented Jan 22, 2022

SuperIceCN commented Jan 26, 2022 • edited

jcaesar commented Jan 26, 2022

sigmasoldi3r commented Jan 27, 2022

jcaesar commented Jan 28, 2022 • edited

beaclnd commented Feb 20, 2022 • edited

EXEC-CSM commented Mar 14, 2022 • edited

EXEC-CSM commented Mar 14, 2022 • edited

beaclnd commented Mar 16, 2022

i059917 commented May 5, 2022 • edited

cafebabe commented May 9, 2022

jcaesar commented May 10, 2022

Hywan commented May 10, 2022

syrusakbary commented May 10, 2022

jcaesar commented May 13, 2022

xjq7 commented Aug 21, 2023

syrusakbary commented Jan 30, 2020 •

edited

SuperIceCN commented Jan 26, 2022 •

edited

jcaesar commented Jan 28, 2022 •

edited

beaclnd commented Feb 20, 2022 •

edited

EXEC-CSM commented Mar 14, 2022 •

edited

EXEC-CSM commented Mar 14, 2022 •

edited

i059917 commented May 5, 2022 •

edited