Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Empty Divs for inline ad #46

Open
amyerz opened this issue Dec 24, 2019 · 0 comments
Open

Collapse Empty Divs for inline ad #46

amyerz opened this issue Dec 24, 2019 · 0 comments

Comments

@amyerz
Copy link

amyerz commented Dec 24, 2019

Expected Behavior

  • collapse empty div behavior for inline ad

Actual Behavior

  • empty div is collapse

Steps to Reproduce the Behavior

ArcAds library has ability to accept configs for collapseEmptyDiv but that collapse only happens at the interior div level - APD repo has to add padding at a parent container level and collapseEmptyDiv doesn't collapse at the parent arcAds component level so if an ad is empty even tho it does collapse at the interior dev arcAds level it does not at that parent container arcAds component level. For that case the padding is still seen even tho there is no ad. Is this an option we can include for arcAds? hiding/collapsing of any parent component divs/ids/classes perhaps?

Additional Comments

Reference to PR for https://github.com/wapopartners/AppleDaily-PageBuilder-Fusion-Features/pull/697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant